Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add textResolver #35
base: main
Are you sure you want to change the base?
feat: add textResolver #35
Changes from all commits
056fb86
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this does look weird honestly, and I am sure it clashes with the existing API. The problem is that conceptually the
textResolver
should be meant for text resolving only, and should not returnComponentNode
at all. This function is not about the node logic at all, but rather about manipulating thecontent
property in whatever the node is.to get same result you have described with solution we should better have the following API:
(the textResolver extends the capability of the node, but does not override it)
Alternatively, we can expect the shape of
textResolver?: (str: string) => Pick<ComponentNode, 'content'>;
and the usage:
but again, this may misslead users that it is not the whole component node but rather just a content, so might be bad alternative.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should return
ComponentNode
for cases when you example you want to support ICU syntax. So in this case all the texts need to be rendered inside some.astro
componentI can suggest to support both outputs:
textResolver?: (str: string) => ComponentNode | string;