Add support to add features during cargo build #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcruz99
reviewed
Dec 4, 2024
lcruz99
reviewed
Dec 4, 2024
Comment on lines
+42
to
+44
| def add_features(self, features: List[str]): | ||
| self.features = features | ||
|
|
There was a problem hiding this comment.
I don't think we even need this method
stalowyjez
reviewed
Dec 6, 2024
| @@ -38,6 +39,9 @@ def __post_init__(self): | |||
| def is_msvc(self): | |||
| return self.rust_target.endswith("-msvc") | |||
|
|
|||
| def add_features(self, features: List[str]): | |||
There was a problem hiding this comment.
I think add implies that the features will be appended, here they are substituted, so I would use set_features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable having custom feature builds.
Motivation comes from resolving this NordSecurity/libtelio#529 (comment), where having a compile time flag seems a better option than passing a feature into telio.