LVPN-7288: Fix HTTP/3 error detection in long responses #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
bartoszWojciechO
force-pushed
the
lvpn-7288_fix_http_rotation
branch
from
5ed2b5e to
35cd322
Compare
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
devzbysiu
reviewed
Mar 5, 2025
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
mariusSincovici
approved these changes
Mar 5, 2025
| envHTTPTransportsKey = "HTTP_TRANSPORTS" | ||
| ) | ||
|
|
||
| // SetBufferSizeForHTTP3 increase receive buffer size to roughly 7.5 MB, as recommended for quic-go library. | ||
| // see: https://github.com/quic-go/quic-go/wiki/UDP-Receive-Buffer-Size | ||
| func SetBufferSizeForHTTP3() error { |
There was a problem hiding this comment.
this was before like this, but if the user configured a bigger value for this then we change it to this.
Maybe create a separate ticket for this to only make this change if the buffer size is smaller?
There was a problem hiding this comment.
Added a ticket.
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
devzbysiu
approved these changes
Mar 5, 2025
bartoszWojciechO
force-pushed
the
lvpn-7288_fix_http_rotation
branch
from
6c5921e to
8ca2f1f
Compare
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
bartoszWojciechO
temporarily deployed
to
Internal
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.