LVPN-5272: Show actual ip address of the user #734

gbaranski · 2025-01-08T13:14:48Z

solved by calling the insights API, and displaying the ip from the insights data

core/models.go

daemon/job_actual_ip.go

daemon/jobs.go

daemon/job_actual_ip.go

daemon/job_actual_ip_test.go

daemon/job_actual_ip.go

daemon/jobs.go

daemon/job_actual_ip.go

daemon/actual_ip_resolver.go

gbaranski requested a review from mariusSincovici January 8, 2025 13:14

keliramu reviewed Jan 8, 2025

View reviewed changes

core/models.go Outdated Show resolved Hide resolved

keliramu changed the title ~~show actual ip address of the user~~ Show actual ip address of the user Jan 9, 2025

gbaranski temporarily deployed to Internal January 9, 2025 11:51 — with GitHub Actions Inactive

gbaranski requested a review from keliramu January 9, 2025 11:51

gbaranski temporarily deployed to Internal January 9, 2025 16:51 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 9, 2025 16:56 — with GitHub Actions Inactive

devzbysiu reviewed Jan 10, 2025

View reviewed changes

daemon/jobs.go Outdated Show resolved Hide resolved

daemon/job_actual_ip.go Outdated Show resolved Hide resolved

gbaranski temporarily deployed to Internal January 10, 2025 08:52 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 13, 2025 09:21 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 13, 2025 10:11 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 13, 2025 11:03 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 13, 2025 12:04 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 13, 2025 12:42 — with GitHub Actions Inactive

mariusSincovici reviewed Jan 14, 2025

View reviewed changes

daemon/job_actual_ip_test.go Outdated Show resolved Hide resolved

daemon/job_actual_ip_test.go Outdated Show resolved Hide resolved

gbaranski temporarily deployed to Internal January 14, 2025 13:28 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 15, 2025 08:48 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 16, 2025 12:22 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 16, 2025 12:41 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 16, 2025 12:53 — with GitHub Actions Inactive

mariusSincovici reviewed Jan 20, 2025

View reviewed changes

gbaranski temporarily deployed to Internal January 22, 2025 12:12 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 22, 2025 12:17 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 23, 2025 09:49 — with GitHub Actions Inactive

gbaranski temporarily deployed to Internal January 23, 2025 09:51 — with GitHub Actions Inactive

gbaranski requested a review from mariusSincovici January 23, 2025 09:52

gbaranski temporarily deployed to Internal January 24, 2025 09:15 — with GitHub Actions Inactive

devzbysiu reviewed Jan 24, 2025

View reviewed changes

daemon/actual_ip_resolver.go Outdated Show resolved Hide resolved

gbaranski requested a review from devzbysiu January 24, 2025 10:39

gbaranski added 27 commits February 26, 2025 10:05

feat: log error for actualIP()

53408bb

fix: mispelling of necessary

1d5f0ba

fix: make requests via api.doWithClient()

00b4553

style: remove trailing newline

bd31ac2

fix: make to actually use InsightsViaTunnel

48c3ff6

fix: do not print error if it is ctx cancellation

5404eba

test: TestInsightsIPUntilSuccess

cfa4a4c

test: TestJobActualIP

5a298e4

fix: use errors.Is instead weird of comparsions

04b3de6

fix: utilize assert library for tests

4129ef9

fix: continue retrying after ip parse error

885b615

fix: call api in a goroutine

2516a51

fix: put each attempt for api in goroutine

5fb1c3d

fix: reorganize the job actual ip related functions

93e2f75

feat: notifying about actual ip update through protobuf

9de4caf

test: TestJobUpdateActualIP

9543255

test: testing ip status in qa tests

2517643

refactor: move JobActualIP out of jobs

2d6bed8

refactor: ActualIP -> ActualIPResolver

b679e6c

fix: handle context cancellation

37c8e76

refactor: now call new fn name

85635b9

fix: cleaner behaviour of update fn

747985b

fix: stop actual ip update if ctx cancelled

f7a2ad5

fix: use a buffered channel for actual ip result

5b7277a

fix: simpliy if else

6c03d27

fix: skip connect events that are attempts

c655fce

test: add EventStatus to DataConnect

94834b0

bartoszWojciechO force-pushed the show-public-ip branch from e3d4d46 to 94834b0 Compare February 26, 2025 09:23

bartoszWojciechO temporarily deployed to Internal February 26, 2025 09:23 — with GitHub Actions Inactive

bartoszWojciechO changed the title ~~Show actual ip address of the user~~ LVPN-5272: Show actual ip address of the user Mar 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LVPN-5272: Show actual ip address of the user #734

LVPN-5272: Show actual ip address of the user #734

gbaranski commented Jan 8, 2025

LVPN-5272: Show actual ip address of the user #734

Are you sure you want to change the base?

LVPN-5272: Show actual ip address of the user #734

Conversation

gbaranski commented Jan 8, 2025