Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fileshare monitoring job #722

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

devzbysiu
Copy link
Contributor

@devzbysiu devzbysiu commented Dec 18, 2024

Changes:

  • no API call for meshnet peers - it uses MachineMap now to get peers
  • job reacts all the time (not only when it detects process state change) - this prevents the corner case of binding to port early and then enabling meshnet to open the port on firewall
  • networker blocks fileshare for all attempts to add the rules (see netw.isFilesharePermitted) as long as the process is down
  • job runs every second instead of 5s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants