New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quench technology #717

Open

bartoszWojciechO wants to merge 30 commits into main from add-quench-technology

Contributor

bartoszWojciechO commented Dec 11, 2024

No description provided.

keliramu reviewed

View reviewed changes

ci/add_private_bindings.sh Outdated Show resolved Hide resolved

bartoszWojciechO force-pushed the add-quench-technology branch from 18934a1 to 8b974f6 Compare

December 12, 2024 09:20

bartoszWojciechO temporarily deployed to Internal

December 12, 2024 09:20

— with

GitHub Actions Inactive

bartoszWojciechO force-pushed the add-quench-technology branch from 8b974f6 to 78484a4 Compare

December 12, 2024 09:26

bartoszWojciechO temporarily deployed to Internal

December 12, 2024 09:26

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 12, 2024 10:31

— with

GitHub Actions Inactive

keliramu reviewed

View reviewed changes

cmd/daemon/main.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

daemon/data_manager.go Show resolved Hide resolved

keliramu reviewed

View reviewed changes

daemon/rpc_connect.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

daemon/rpc_connect.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

daemon/servers.go Show resolved Hide resolved

keliramu reviewed

View reviewed changes

tunnel/tunnel.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

config/remote/firebase.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

config/remote/firebase.go Outdated Show resolved Hide resolved

keliramu reviewed

View reviewed changes

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

mariusSincovici reviewed

View reviewed changes

ci/generate_protobuf.sh Outdated Show resolved Hide resolved

daemon/rpc_set_technology.go Outdated Show resolved Hide resolved

cmd/daemon/no_firebase_cfg.go Show resolved Hide resolved

cmd/daemon/vpn_factory.go Outdated Show resolved Hide resolved

cli/cli_set_technology.go Outdated Show resolved Hide resolved

core/models_test.go Show resolved Hide resolved

daemon/rpc_connect.go Outdated Show resolved Hide resolved

daemon/rpc_connect.go Outdated Show resolved Hide resolved

features/no_quench.go Outdated Show resolved Hide resolved

bartoszWojciechO temporarily deployed to Internal

December 17, 2024 07:44

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 17, 2024 08:22

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 18, 2024 12:36

— with

GitHub Actions Inactive

bartoszWojciechO force-pushed the add-quench-technology branch from 3af851c to 7ddb9a1 Compare

December 18, 2024 12:37

bartoszWojciechO temporarily deployed to Internal

December 18, 2024 12:37

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 18, 2024 14:31

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 06:18

— with

GitHub Actions Inactive

bartoszWojciechO force-pushed the add-quench-technology branch from 16f0876 to 62e0711 Compare

December 19, 2024 06:24

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 06:24

— with

GitHub Actions Inactive

bartoszWojciechO force-pushed the add-quench-technology branch from 62e0711 to b760ba7 Compare

December 19, 2024 06:30

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 06:30

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 07:50

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 07:57

— with

GitHub Actions Inactive

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 09:14

— with

GitHub Actions Inactive

bartoszWojciechO added 6 commits

December 19, 2024 10:31


          only compile qunech when quench is enabled

bac4d75


          update error message

7fd4275


          remove debug change

47ce157


          fix moose-events path

3369c73


          remove debug changes

9ec55f8


          remove quench tag from unit tests

844571d

bartoszWojciechO force-pushed the add-quench-technology branch from 146d63e to 844571d Compare

December 19, 2024 09:31

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 09:31

— with

GitHub Actions Inactive


          Remove tech fallback from rpc_connect.go

850082c

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 11:18

— with

GitHub Actions Inactive

mariusSincovici reviewed

View reviewed changes

daemon/jobs.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go Show resolved Hide resolved

daemon/vpn/quench/libquench.go Show resolved Hide resolved

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved


          update go toolchain

9e72f5d

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 11:49

— with

GitHub Actions Inactive


          fix technology name in nordvpn status

e75fa3f

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 14:59

— with

GitHub Actions Inactive


          Add autocomplete

a744eba

bartoszWojciechO temporarily deployed to Internal

December 19, 2024 15:22

— with

GitHub Actions Inactive

keliramu reviewed

View reviewed changes

daemon/rpc_is_quench_enabled.go Outdated

+              	"github.com/NordSecurity/nordvpn-linux/features"
+              )
+              func (r *RPC) isNordWhisperEnabled() bool {

Contributor

keliramu Dec 19, 2024

Is there a need for 2 fns here? I dont see why...

Contributor Author

bartoszWojciechO Dec 20, 2024

The inner function is also used in jobs.go and rpc_settings.go, just to check if quench is enabled. Outer function also wraps the result in an RPC response.

bartoszWojciechO added 2 commits

December 19, 2024 17:22


          review fixes

2b7dd90


          rename pb file

bartoszWojciechO temporarily deployed to Internal

December 20, 2024 08:57

— with

GitHub Actions Inactive


          set quench log prefix based on reported quench log level

703236f

bartoszWojciechO temporarily deployed to Internal

December 20, 2024 09:04

— with

GitHub Actions Inactive

keliramu approved these changes

View reviewed changes

devzbysiu approved these changes

View reviewed changes

daemon/rpc_is_quench_enabled.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go

Comment on lines +280 to +283

+              	if q.tun != nil {
+              		return q.tun
+              	}
+              	return nil

Contributor

devzbysiu Dec 20, 2024

[small] can be just return q.tun?

Contributor Author

bartoszWojciechO Dec 20, 2024

I think this is the same case as https://go.dev/doc/faq#nil_error.

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

daemon/vpn/quench/libquench.go Outdated Show resolved Hide resolved

config/remote/remote_config.go Outdated Show resolved Hide resolved

config/remote/firebase.go Outdated Show resolved Hide resolved

cmd/daemon/vpn_telio.go Outdated Show resolved Hide resolved

cmd/daemon/vpn_no_quench.go Outdated Show resolved Hide resolved

bartoszWojciechO added 2 commits

December 20, 2024 16:40


          review fixes

07c518b


          linter fixes

05055f4

bartoszWojciechO temporarily deployed to Internal

December 20, 2024 15:42

— with

GitHub Actions Inactive


          fix crash on nordvpn connect

0ca78b0

bartoszWojciechO temporarily deployed to Internal

December 20, 2024 16:03

— with

GitHub Actions Inactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet