-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fileshare process monitoring #713
Conversation
3d42d46
to
ea1668c
Compare
ea1668c
to
616f98f
Compare
647e3ba
to
4a72621
Compare
4a72621
to
8efd9d9
Compare
8efd9d9
to
72b1823
Compare
c8fc770
to
c998da9
Compare
2051eae
to
8f2cd5f
Compare
meshnet/monitor_event_handler.go
Outdated
// of creation of [FilesharePortAccessController] - constructor checks | ||
// if nordfilshare is already running - so we know that nordfileshare | ||
// PID will be higher than the daemon PID. | ||
if ev.PID < eventHandler.processChecker.CurrentPID() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would happen if PIDs are recycled or if the numbering is restarted(when max int was reached) by the kernel ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Not sure how likely this it. I'll measure the performance without this if check, because it will read /proc
for all new processes then
95a7f9e
to
df68940
Compare
9063759
to
b52effa
Compare
b52effa
to
7e2e157
Compare
7e2e157
to
aac960b
Compare
The Process Event Connector mechanism is not working on docker because of process and user namespaces mismatch and it's not reporting errors to user-space. I'm dropping this approach. |
Changes:
JobMonitorFileshareProcess
replaced withNetlinkProcessMonitor
- based on netlink Process Events Connector API:/proc
VFS to check the process path