Prevent using RoundTripper after it was closed #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusSincovici
commented
Jul 4, 2024
keliramu
reviewed
Jul 4, 2024
keliramu
reviewed
Jul 4, 2024
keliramu
approved these changes
Jul 8, 2024
devzbysiu
approved these changes
Jul 8, 2024
Signed-off-by: Marius Sincovici <[email protected]> The inner RoundTripper can be used by multiple requests in the same time. It can be closed on error or on VPN connection. This 2 operation can overlap resulting in a crash because requests are using a closed RoundTripper. To prevent the crash protect access to RoundTripper with a RWLock. Plus add an atomic.Bool to prevent recreating RoundTripper by 2 concurrent requests on the same error.
mariusSincovici
force-pushed
the
fix-race-condition-for-round-tripper
branch
from
021798a to
64791dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marius Sincovici [email protected]
The inner
RoundTrippercan be used by multiple requests in the same time. It can be closed on error or on VPN connection. This 2 operation(execute reques + close) can overlap resulting in a crash because requests are using a closedRoundTripper.To prevent the crash protect access to
RoundTripperwith aRWLock. Plus add anatomic.Boolto prevent recreating RoundTripper by 2 concurrent requests on the same error.