Update libdrop #477
Merged
Update libdrop #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devzbysiu
commented
Jun 27, 2024
devzbysiu
commented
Jun 27, 2024
devzbysiu
commented
Jun 27, 2024
fileshare/transfer.go
Outdated
| allFinished := true | ||
| hasNoErrors := true | ||
| hasStarted := false | ||
| for _, file := range files { |
There was a problem hiding this comment.
[minor] if you want you can simplify the bellow ifs allCanceled = allCanceled && file.Status != pb.Status_CANCELED
There was a problem hiding this comment.
Sure 👍 , I'll take a look after I have all the tests green 😄
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
7 times, most recently
from
d410374 to
0443904
Compare
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
3 times, most recently
from
ad11350 to
63171a0
Compare
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
3 times, most recently
from
e877830 to
c9630db
Compare
Savolro
suggested changes
Jul 16, 2024
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
6 times, most recently
from
27a0a14 to
4b421e1
Compare
keliramu
reviewed
Jul 19, 2024
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
3 times, most recently
from
262176a to
59cb033
Compare
devzbysiu
force-pushed
the
LVPN-3365-dynamic-linking
branch
from
621dfa1 to
c38280c
Compare
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
from
430b472 to
2c7ee33
Compare
devzbysiu
force-pushed
the
LVPN-3365-dynamic-linking
branch
from
c38280c to
d86e2b0
Compare
Savolro
approved these changes
Aug 21, 2024
bartoszWojciechO
approved these changes
Aug 21, 2024
devzbysiu
force-pushed
the
LVPN-5188-foss-update-libdrop
branch
from
2c7ee33 to
17f6980
Compare
devzbysiu
added a commit
that referenced
this pull request
Aug 22, 2024
devzbysiu
added a commit
that referenced
this pull request
Aug 23, 2024
devzbysiu
added a commit
that referenced
this pull request
Aug 29, 2024
devzbysiu
added a commit
that referenced
this pull request
Aug 30, 2024
devzbysiu
added a commit
that referenced
this pull request
Sep 9, 2024
devzbysiu
added a commit
that referenced
this pull request
Sep 9, 2024
devzbysiu
added a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to libdrop
v7.0.0