Save remote config when there is no error (#152)

Signed-off-by: Marius Sincovici <[email protected]>

config/remote/firebase.go

@@ -100,7 +100,7 @@ func (rc *RConfig) fetchAndSaveRemoteConfig() (remoteConfig []byte, err error) {
 	defer func() {
 		errCfgSave := rc.configManager.SaveWith(func(c config.Config) config.Config {
 			c.RCLastUpdate = time.Now()
-			if err != nil {
+			if err == nil {
 				c.RemoteConfig = string(remoteConfig)
 			}
 			return c

config/remote/firebase_test.go

@@ -10,6 +10,7 @@ import (
 	"github.com/NordSecurity/nordvpn-linux/config"
 	"github.com/NordSecurity/nordvpn-linux/test/category"
 	"github.com/NordSecurity/nordvpn-linux/test/mock"
+	"google.golang.org/api/firebaseremoteconfig/v1"
 
 	"github.com/stretchr/testify/assert"
 )
@@ -368,6 +369,17 @@ func TestRemoteConfig_GetCachedData(t *testing.T) {
 			} else {
 				assert.NoError(t, err)
 			}
+
+			// check if cache remote config is the same as the fetch
+			if test.remoteConfig != "" {
+				var cfgExpected firebaseremoteconfig.RemoteConfig
+				assert.NoError(t, json.Unmarshal([]byte(test.remoteConfig), &cfgExpected))
+
+				var cfg firebaseremoteconfig.RemoteConfig
+				assert.NoError(t, json.Unmarshal([]byte(cm.Cfg.RemoteConfig), &cfg))
+
+				assert.Equal(t, cfgExpected, cfg, "fetch RC different from saved one")
+			}
 		})
 	}
 }