Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DERP userspace keepalives #974

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Add DERP userspace keepalives #974

merged 1 commit into from
Dec 20, 2024
+328 −83

Conversation

dfetti
Copy link
Contributor

@dfetti dfetti commented Nov 22, 2024 •
edited
Loading

This PR adds DERP userspace keepalive to libtelio. (Unbatched for now)

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@dfetti dfetti requested a review from a team as a code owner November 22, 2024 08:19
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from d5be027 to 032d6fc Compare November 26, 2024 10:49
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 032d6fc to f1ff82b Compare November 26, 2024 10:49
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from f1ff82b to d510c1d Compare November 27, 2024 17:32
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from d510c1d to 84b7791 Compare November 28, 2024 08:09
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 84b7791 to 9c41e3d Compare November 28, 2024 16:36
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from fd4b200 to 2d9d047 Compare December 16, 2024 17:57
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 2d9d047 to d43d674 Compare December 16, 2024 18:19
@dfetti dfetti changed the title Draft: Add DERP userspace keepalives Add DERP userspace keepalives Dec 16, 2024
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from d43d674 to 82ade69 Compare December 16, 2024 18:25
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 82ade69 to b979f26 Compare December 16, 2024 18:26
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from b979f26 to 013b69b Compare December 17, 2024 07:56
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 013b69b to 663e5c4 Compare December 18, 2024 07:54
LukasPukenis
LukasPukenis reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@LukasPukenis LukasPukenis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good but needs some improvements

crates/telio-relay/src/derp.rs Outdated Show resolved Hide resolved
crates/telio-relay/src/derp.rs Outdated Show resolved Hide resolved
crates/telio-relay/src/derp/http.rs Outdated Show resolved Hide resolved
nat-lab/tests/test_derp_connect.py Outdated Show resolved Hide resolved
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 663e5c4 to 4a7cdfa Compare December 18, 2024 10:00
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 4a7cdfa to e967761 Compare December 18, 2024 10:01
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from e967761 to 6c7b4ab Compare December 18, 2024 10:03
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 6c7b4ab to dd0efad Compare December 18, 2024 10:07
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from dd0efad to 54ba4e1 Compare December 18, 2024 10:10
tomaszklak
tomaszklak reviewed Dec 18, 2024
View reviewed changes
crates/telio-model/src/features.rs Show resolved Hide resolved
crates/telio-relay/src/derp/http.rs Outdated Show resolved Hide resolved
crates/telio-relay/src/derp/http.rs Outdated Show resolved Hide resolved
crates/telio-relay/src/derp/http.rs Outdated Show resolved Hide resolved
crates/telio-relay/src/derp/http.rs Outdated Show resolved Hide resolved
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 54ba4e1 to 5ac7124 Compare December 19, 2024 07:50
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 5ac7124 to 774030d Compare December 19, 2024 07:58
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 774030d to be802f9 Compare December 19, 2024 08:02
tomaszklak
tomaszklak reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@tomaszklak tomaszklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from be802f9 to 00ea6b1 Compare December 20, 2024 12:27
@dfetti
Add DERP userspace keepalives
ca38b39 
More info on that in RFC-LLT-0070

Signed-off-by: Daniel Fetti <[email protected]>
@dfetti dfetti force-pushed the LLT-5639-userspace-derp-keepalives branch from 00ea6b1 to ca38b39 Compare December 20, 2024 12:27
@lcruz99
Copy link
Contributor

lcruz99 commented Dec 20, 2024

+1

lcruz99
lcruz99 approved these changes Dec 20, 2024 •
edited
Loading
View reviewed changes
@dfetti dfetti enabled auto-merge December 20, 2024 13:21
@dfetti dfetti merged commit 26fe43a into main Dec 20, 2024
66 of 67 checks passed
@dfetti dfetti deleted the LLT-5639-userspace-derp-keepalives branch December 20, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszklak tomaszklak tomaszklak left review comments

@LukasPukenis LukasPukenis LukasPukenis left review comments

@lcruz99 lcruz99 lcruz99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dfetti @lcruz99 @LukasPukenis @tomaszklak