Bring back stricter events assertion in test-direct-working-path test #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in order to enable easier reproduction of the issue
Jauler
force-pushed
the
LLT-5775_investigate_test_direct
branch
from
789b3f2 to
b4f3b13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I have a feeling that recent PR #927 could have made test-direct-working-path a little too loose. For this reason I am bringing back a bit stricter events assertion and will try to reproduce previous the test-direct-working-path failure. With the reproduction, will attempt to find exact root cause for the failure, and hopefully in the end, gather enough information, to enable the test to get back to stricter events verification.
☑️ Definition of Done checklist