PoC: Rust-based integration test PoC #879
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-grz
reviewed
Oct 22, 2024
| } | ||
|
|
||
| pub fn configure_ifc(ifc_name: &str, ip: IpAddr) { | ||
| run_command( |
There was a problem hiding this comment.
I guess this wouldn't work running the tests on macOS because it uses ifconfig for interface management. as far as I know there is no one cross-platform crate for doing so, only retrieving the configuration..
| tun: None, | ||
| }) | ||
| .unwrap(); | ||
| self.dev.set_fwmark(11673110).unwrap(); |
There was a problem hiding this comment.
This also fails on macOS with
--> systests/src/utils/test_client.rs:86:18
|
86 | self.dev.set_fwmark(11673110).unwrap();
| ^^^^^^^^^^ method not found in `Device`
| @@ -0,0 +1,59 @@ | |||
| [package] | |||
| name = "systests" | |||
There was a problem hiding this comment.
Would be nice to have a readme.md with some minimal instructions
| mod tests; | ||
| mod utils; | ||
|
|
||
| fn main() { |
There was a problem hiding this comment.
why don't we use the tests module approach here?
#[cfg(test)]
mod test_vpn {
use super::*;
#[test]
fn test_vpn_poc_works() {
test_vpn_poc();
}
}then we could get nicer test result reports like
thread 'test_vpn::test_vpn_poc_works' panicked at systests/src/tests/vpn.rs:51:5:
assertion failed: false
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Successfully executed 'ip link delete tun10'
Successfully executed 'ip rule del priority 32111'
failures:
test_vpn::test_vpn_poc_works
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.22s
|
I've been able to quickly run the tests with both methods. Running the binary took half the time than with Great job!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a PoC that should not be merged.
The purpose of this PR is to showcase two different methods of implementing rust-based integration tests for libtelio, to make discussing a related RFC easier.
The goal before anything related to this effort is merged is to not have any external dependencies that are not runnable and manageable directly from the test (starting a separate process from Rust to run separate binaries doesn't count), but to be able to start the RFC process, this PR only localizes the derp servers to rust. Because of that, the PoC vpn connection test cannot be run without at least the natlab vpn containers running
☑️ Definition of Done checklist