Capture output from docker compose logs on failure #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olekoliinyk
force-pushed
the
olekoliinyk/get_docker_compose_log_on_failure
branch
from
fc0af4d to
8b2a65a
Compare
olekoliinyk
changed the title
|
+1.0 |
olekoliinyk
force-pushed
the
olekoliinyk/get_docker_compose_log_on_failure
branch
from
8b2a65a to
f9653f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a container fails to start during
docker compose up, the failure is not printed out because the exception is not being handled.Also, in
core-apicontainer, the re-tries is missing for the healthcheck.Solution
Catch the
CalledProcessErrorexception and invokecheck_containersmethod to output information fromdocker compose logs <service>☑️ Definition of Done checklist