-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libtelio dependencies #1066
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing .unreleased
entry. Though the PR itself looks OK and the linked pipeline reveals only one failed job due to Windows VM.
One thing that needs to be addressed - pqcrypto-internals
update, it fails on our current Mac builders and I've manually reverted it not long ago so you will need to do that or else it will not build for apple with our runners :). This one is blocking
However without it +1
netmask: Ipv4Addr::new(255, 0, 0, 0), | ||
prefixlen: 8, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by the diff, the netmask was incorrect but the unit test was not failing. Is it possible to make it unit-tested as well while we're at it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was not failing because the code does not care about this netmask at all, and there is not reason to test it. If there was a Default implementation for Ifv4Addr we could use it, but there is not, so we need to initialize it with some dummy data
bd96e0a
to
93fd12c
Compare
93fd12c
to
0a147e9
Compare
0a147e9
to
848339a
Compare
☑️ Definition of Done checklist