Make pollKeepalive optional #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszklak
force-pushed
the
fix-pollKeepalive
branch
from
e60f339 to
3493a91
Compare
tomasz-grz
approved these changes
Dec 23, 2024
We didn't release version with this new field so as far as I understand, if we release 5.2 after this PR it will be just like the addition of non-optional didn't happen. Which means that we added optional field which is afaik compatible with applications using previous (5.1.5) version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pool_keepalivewas made a required field. This is causing failures in unaligned clients (the fact that it has a default serde value in the json doesn't help).Solution
Make the field optional in the udl.
☑️ Definition of Done checklist