Misalign batch testcase peers and add scoring #1044
+103
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
force-pushed
the
LLT-5876_better_batching_testcase
branch
from
7d1b21b to
4335ef9
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
* Add 4 peers instead of 2 to batching testcase * Misalign them by starting each with a delay. This one is synthetic since in real world peers don't usually start all at the same time and establish direct connections but in testcase it's still worth to have. * Misalign further by blocking alpha<->beta for a while so they would establish direct connection later than with other peers thus having a misalignment similar to real world. * Add scoring to distribution histogram. It can now be quantified how better/worse some solution or scenario is. For now it's just added to be printed Signed-off-by: Lukas Pukenis <[email protected]>
LukasPukenis
force-pushed
the
LLT-5876_better_batching_testcase
branch
from
4335ef9 to
7b8f3a9
Compare
LukasPukenis
temporarily deployed
to
Internal
GitHub Actions
Inactive
LukasPukenis
changed the title
dfetti
reviewed
Dec 20, 2024
| BATCHING_MISALIGN_S = 7 | ||
| BATCHING_CAPTURE_TIME = 120 # Tied to TEST_BATCHING_TIMEOUT | ||
| BATCHING_CAPTURE_TIME = 130 | ||
| DOCKER_CONE_GW_2_IP = "10.0.254.2" |
There was a problem hiding this comment.
These IP is also defined in test_direct_connection.py. Maybe you can put them all in config.py or somewhere to avoid redefinitions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Batching testcase was too ideal, just two peers and they interconnect immediately
Solution
This required to proceed with peer initialization manually instead of using the regular helpers
☑️ Definition of Done checklist