[LLT-5831] teliod cgi api #1041
Open
+804
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packgron
force-pushed
the
LLT-5865_cgi_skeleton
branch
2 times, most recently
from
38a4f90 to
61b4b22
Compare
Original work done in #1012. This is restructure and reabase on common base.
packgron
force-pushed
the
LLT-5831_cgi_api
branch
from
6a8b7f6 to
dc45504
Compare
lcruz99
reviewed
Dec 19, 2024
Comment on lines
+3
to
+15
| #[cfg(feature = "qnap")] | ||
| mod consts { | ||
| use super::*; | ||
|
|
||
| pub const APP_DIR: &str = "/share/CACHEDEV1_DATA/.qpkg/NordSecurityMeshnet"; | ||
| } | ||
|
|
||
| #[cfg(not(feature = "qnap"))] | ||
| mod consts { | ||
| pub const APP_DIR: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/target/debug"); | ||
| } | ||
|
|
||
| use consts::*; |
There was a problem hiding this comment.
why not directly do this? readability?
Suggested change
| #[cfg(feature = "qnap")] | |
| mod consts { | |
| use super::*; | |
| pub const APP_DIR: &str = "/share/CACHEDEV1_DATA/.qpkg/NordSecurityMeshnet"; | |
| } | |
| #[cfg(not(feature = "qnap"))] | |
| mod consts { | |
| pub const APP_DIR: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/target/debug"); | |
| } | |
| use consts::*; | |
| #[cfg(feature = "qnap")] | |
| pub const APP_DIR: &str = "/share/CACHEDEV1_DATA/.qpkg/NordSecurityMeshnet"; | |
| #[cfg(not(feature = "qnap"))] | |
| pub const APP_DIR: &str = concat!(env!("CARGO_MANIFEST_DIR"), "/target/debug"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
REST API to be used by static web to controll teliod daemon
Solution
☑️ Definition of Done checklist