Add nat-lab test for starting telio with an existing tunnel #1038
+113
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrasherLT
force-pushed
the
start_telio_with_tun_natlab_test
branch
from
20545ce to
f420fdd
Compare
Also fix some bugs found on the way.
ThrasherLT
force-pushed
the
start_telio_with_tun_natlab_test
branch
from
f420fdd to
256e811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
start_with_tunffi function wasn't being tested and thus contained bugs on platforms which weren't using that function in production.Solution
Added a nat-lab test for
start_with_tunfunction and fixed multiple bugs found on the way.☑️ Definition of Done checklist