LLT-5866: Remove app_user_uid from the config. #1023
Conversation
tomasz-grz
force-pushed
the
teliod_uid
branch
from
deb220f to
488ab7e
Compare
clis/teliod/src/nc.rs
Outdated
| let callbacks = Arc::new(Mutex::new(vec![])); | ||
|
|
||
| let nc_config = NCConfig { | ||
| authentication_token: config.authentication_token.clone(), | ||
| app_user_uid: config.app_user_uid, | ||
| app_user_uid: *hw_identifier, |
There was a problem hiding this comment.
nit: maybe rename NCConfig's app_user_uid to hw_id?
There was a problem hiding this comment.
From MQTT API point of view this field is still called app_user_uid. I could change the NCConfig but TokenHttpRequestwould still have to remain app_user_uid otherwise it would break the HTTP request.
I would rather change the new() signature for more consistency.
|
+1 |
tomasz-grz
force-pushed
the
teliod_uid
branch
from
488ab7e to
6f0f702
Compare
tomasz-grz
force-pushed
the
teliod_uid
branch
from
6f0f702 to
1c79a2d
Compare
|
What is the difference between |
tomasz-grz
force-pushed
the
teliod_uid
branch
from
1c79a2d to
8c3f6ca
Compare
tomasz-grz
force-pushed
the
teliod_uid
branch
from
8c3f6ca to
0b5a266
Compare
|
@Hasan6979 One is used to identify the device on meshnet, and the other to identify the device for MQTT subscriptions.
|
tomasz-grz
force-pushed
the
teliod_uid
branch
from
0b5a266 to
30fd1fe
Compare
| let mut identity_path = dirs::data_local_dir().ok_or(Error::NoDataLocalDir)?; | ||
| identity_path.push("teliod"); | ||
| if !identity_path.exists() { | ||
| let _ = create_dir_all(&identity_path); | ||
| } | ||
| identity_path.push(&format!("{interface_name}.json")); | ||
| identity_path.push("data.json"); |
There was a problem hiding this comment.
what's the reason behind this change?
There was a problem hiding this comment.
Based from the discussions on slack, we want to destroy the old config if we switch users.
Currently, if you change the interface name in the config file, it will create a new identity file leaving the old one behind.
Problem
Currently
app_user_idused for notification center is part of the user provided config for teliod. It shouldn’t be user configurable, we can reuse the the meshnethardware_idfor it instead which should be generated when the device is registered.Solution
Remove
app_user_uidfrom the user config.Use a randomly generated UUID instead of the public key for
hw_identifier.Use the
hw_identifierasapp_user_uidin notification center.☑️ Definition of Done checklist