Skip to content

Commit

Permalink
Refactor batcher and inline into SessionKeeper
Browse files Browse the repository at this point in the history
This commit does these things:
- Inlines batching flag to SessionKeeper, removing batcher entirely
as a separate entity with all of its logic(threshold, traffic trigger).
- Emits all actions from SessionKeeper if batching is enabled when
an action is added. This works nicely if we can guarantee that actions
are gonna be a multiple of some T which is the case as currently we
target T=70s for proxy, direct, vpn, stun keepalives. This also makes
thresholds and the whole logic around them irrelevant.

Traffic triggered batching implementation was doing more harm than good
since it triggers on _any_ traffic, meaning even when alignment was
achieved, it might misalign since any traffic triggers it.

Feature flags are not removed in this commit so not to push for
version update of libtelio, so now they are no-op.

Signed-off-by: Lukas Pukenis <[email protected]>

Signed-off-by: Lukas Pukenis <[email protected]>
  • Loading branch information
LukasPukenis committed Dec 18, 2024
1 parent 07f2d21 commit c61628a
Show file tree
Hide file tree
Showing 8 changed files with 190 additions and 1,618 deletions.
1 change: 1 addition & 0 deletions .unreleased/LLT-5857
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Refactor batcher
Loading

0 comments on commit c61628a

Please sign in to comment.