FILE-613: retrieve private key always #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
changed the title
Lipt0nas
reviewed
Jul 30, 2024
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
2 times, most recently
from
ba6b4eb to
b71daed
Compare
Lipt0nas
previously approved these changes
Jul 30, 2024
matszczygiel
reviewed
Aug 5, 2024
matszczygiel
reviewed
Aug 5, 2024
matszczygiel
reviewed
Aug 5, 2024
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
from
b71daed to
4216f84
Compare
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
from
4216f84 to
2dd815e
Compare
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
2 times, most recently
from
8ab40ac to
52a7f91
Compare
|
@matszczygiel addressed the comments |
matszczygiel
previously approved these changes
Sep 23, 2024
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
2 times, most recently
from
da0c702 to
c30cbeb
Compare
Previously it was cached after the first call and it so happens that the key might sometimes change. Due to FFI layer issues, Libdrop instance cannot be destroyed and recreated thus leaving the only solution either a new API or the easier one - passing KeyStore in Arc<> and calling when needed. Signed-off-by: Lukas Pukenis <[email protected]>
LukasPukenis
force-pushed
the
FILE-613_retrieve_private_key_always
branch
from
c30cbeb to
9704105
Compare
matszczygiel
approved these changes
Sep 23, 2024
|
All comments addressed @Lipt0nas @matszczygiel . I gave a pipeline build to Windows to test. The tests failing in natlab are due to flakyness |
Lipt0nas
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Private key retrieval was previously done on
device::new()once and stored, however API users sometimes hcange the private key and need to recreate libdrop instance. However it's no tthe ideal way of doing things and thus this PR just queries for the private key each time it needs.