Implement automatic transfer cancelation #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matszczygiel
force-pushed
the
msz/FILE-534-implement-automatic-transfer-cancellation
branch
8 times, most recently
from
191e2b9 to
edf3f39
Compare
matszczygiel
force-pushed
the
msz/FILE-534-implement-automatic-transfer-cancellation
branch
3 times, most recently
from
4c8b4b2 to
2dd55b6
Compare
Lipt0nas
previously approved these changes
Jul 15, 2024
matszczygiel
force-pushed
the
msz/FILE-534-implement-automatic-transfer-cancellation
branch
from
2dd55b6 to
5e75db1
Compare
Signed-off-by: Mateusz Szczygieł <[email protected]>
Signed-off-by: Mateusz Szczygieł <[email protected]>
Signed-off-by: Mateusz Szczygieł <[email protected]>
Signed-off-by: Mateusz Szczygieł <[email protected]>
matszczygiel
force-pushed
the
msz/FILE-534-implement-automatic-transfer-cancellation
branch
from
5e75db1 to
c6deb3f
Compare
Lipt0nas
approved these changes
Jul 15, 2024
matszczygiel
deleted the
msz/FILE-534-implement-automatic-transfer-cancellation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the automatic cancelation feature. This is done by checking on each file reaching any terminal state to see if there's any file not yet in the terminal state. If there isn't, the transfer is automatically canceled by the peer who receives the notification about the file state change.
Additionally, I've implemented a check upon establishing the connection to see if the transfer should be canceled based on file states to account for transfers created by old libdrop versions and to be double sure the mechanism works.