Fix bad socket creation, bad socket configuration and lock within lock #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThrasherLT
force-pushed
the
LLT-5351_v060_slowdowns
branch
2 times, most recently
from
1abe2cf to
d0ac48b
Compare
Jauler
reviewed
Jul 16, 2024
| @@ -482,7 +482,7 @@ mod tests { | |||
| fn test_wireguard_set() { | |||
| let port = next_port(); | |||
| let private_key = StaticSecret::random_from_rng(OsRng); | |||
| let own_public_key = PublicKey::from(&private_key); | |||
| let _own_public_key = PublicKey::from(&private_key); | |||
There was a problem hiding this comment.
🤔 maybe it is worth removing it this, if own_public_key is not used?
Jauler
reviewed
Jul 16, 2024
Jauler
reviewed
Jul 16, 2024
boringtun/src/device/mod.rs
Outdated
| let mut iter = MAX_ITR; | ||
|
|
||
| let mut public_key = String::with_capacity(32); | ||
| for byte in peer.lock().tunnel.peer_static_public().as_bytes() { | ||
| let mut p = peer.lock(); |
There was a problem hiding this comment.
Won't this mean, that peer lock is held while receive loop is running?
ThrasherLT
force-pushed
the
LLT-5351_v060_slowdowns
branch
from
b2b659d to
8deb64b
Compare
packgron
reviewed
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v0.6.0 introduced bugs due to which traffic became around 50 times slower. This was due to:
Bad socket configuration by Cloudflare.
Bad socket protection on our side.
A lock within a lock on our side.
So all of this is fixed with this PR.
Also added a unit test to validate connected socket creation since the other issues can be easily caught with our current nat-lab tests.
And besides that fixed some older warnings about deprecated functions and unused variables.