Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes needed to add dglc component for cdeps #72

Closed
wants to merge 417 commits into from

Conversation

mvertens
Copy link

@mvertens mvertens commented Apr 1, 2024

This provides changes to the CESM config_files and Makefile that permits a new dglc component to be added to cdeps.
This change will only effect CESM and NorESM.

Test suite: Testing was done with the new dglc component in place and will not effect any other CESM/NorESM configurations.
Test baseline:
Test namelist changes:
Test status: bit-for-bit

Fixes: None

User interface changes?: No

Update gh-pages html (Y/N)?: No

jasonb5 and others added 30 commits July 29, 2023 00:39
if the config_machines.xml file cannot be found give a meaningful error
Adds skip-submit argument to case.build
change method of detecting fv3 dycore in cam and path to libfv3.a
add which to find ncdump and an error message if not found
do not allow EXEROOT or OBJDIR or LIBROOT to be CASEROOT
Emphasised two points on how to use SourceMods to modify a case.

1. The name of the xmlchange shell file should be shell_commands
2. SourceMods changes do not need to have the same strucutre as the component source codes
Update create-a-case.rst with how to use SourceMods
Add flexible controls of GPU configuration (docs test expected to fail and will update on merge. )
Removes DAE.ww3a.ADWAV from cime_developers

Remove DAE.ww3a.ADWAV from cime_developers. E3SM has removed
the ww3a grids, which caused this to fail.

Test suite: ./scripts/create_test cime_developer
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N
Fixes hist_files excluding components during actual compare

We were only excluding components during the copy_histfiles,
need to exclude during _compare_hists as well otherwise
compare_phase complains it cannot find counterpart of old
baseline files.

Test suite: pytest CIME/tests/*
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes n/a
User interface changes?: N
Update gh-pages html (Y/N)?: N
jedwards4b and others added 27 commits December 15, 2023 10:05
remove SMP_PRESENT and replace with BUILD_THREADED
It's removal in ESMCI#4546 seems to have broken a number of
less-common test types (ERR, MCC, IRT, PRE).
.. so all the subclasses don't have to remember to do it.
It's removal in ESMCI#4546 seems to have broken a number of less-common test types (ERR, MCC, IRT, PRE).

MCC_P1.f19_g16_rx1.A
ERROR: ERROR: must invoke case.setup script before calling build script
ERR_Ln9.f45_g37_rx1.A
Exception from case_test: [Errno 2] No such file or directory: '/scratch/jenkins-slave/workspace/CIME_DEVELOPER_TESTS_MASTER/archive/ERR_Ln9.f45_g37_rx1.A.anlgce_gnu.20240102_114925_1cza5r/rest'
Exception from case_test: [Errno 20] Not a directory: '/scratch/jenkins-slave/workspace/CIME_DEVELOPER_TESTS_MASTER/ERR_Ln9.f45_g37_rx1.A.anlgce_gnu.20240102_114925_1cza5r/run/case2run/timing'
IRT_N2_Vmct_Ln9.f19_g16_rx1.A
Exception from case_test: [Errno 20] Not a directory: '/scratch/jenkins-slave/workspace/CIME_DEVELOPER_TESTS_MASTER/IRT_N2_Vmct_Ln9.f19_g16_rx1.A.anlgce_gnu.20240102_114925_1cza5r/run/case2run/timing'
PRE.f19_f19.ADESP
Exception from case_test: ERROR: Do not know about batch job case.test
Test suite: the test cases above, by hand
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:
When an env var value is None, this tells CIME to unset the environment. This
use case was not being handled in the creation of .env_mach_specific.sh.
…l_env

Fix .env_mach_specific.sh when unsetting env

When an env var value is None, this tells CIME to unset the environment. This use case was not being handled in the creation of .env_mach_specific.sh.

Test suite: by-hand
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:
@mvertens mvertens requested a review from gold2718 April 1, 2024 09:04
@mvertens
Copy link
Author

mvertens commented Apr 1, 2024

This PR was incorrect.

@mvertens mvertens closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.