add BLOM specific settings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt routine for ocn component
This reverts commit d4b8441.
…miscellaneous cleanup
…tialization time saver
update the minimum esmf version requirement
make history_n integer variables
CESM_COUPLED should be CESMCOUPLED
Aux cpl hist daily
add new optional mapping of taux and tauy from ocean to wave
make xgrid default and fix sw flux to mom ocn
gold2718
approved these changes
May 25, 2023
| ) | ||
| else: | ||
| expect(int(minor) >= 1, "ESMF version should be 8.1.0 or newer") | ||
| expect(int(major) >= 8 and int(minor) >=4, "ESMF version should be 8.4.1 or newer") |
There was a problem hiding this comment.
This logic only works for int(major) == 8. EMF 9.1 or 9.3 would fail. I would prefer:
Suggested change
| expect(int(major) >= 8 and int(minor) >=4, "ESMF version should be 8.4.1 or newer") | |
| expect(int(major) >= 8, "ESMF version should be 8.4.1 or newer") | |
| expect(int(major) > 8 or int(minor) >=4, "ESMF version should be 8.4.1 or newer") |
There was a problem hiding this comment.
@gold2718 - the above did not work for ESMF 8.4.1 - so I'm happy to look at this later - but I'd like to get this PR merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
BLOM specific settings have been added to config_component_cesm.xml
Specific notes
In addition the code has been updated to cmeps0.14.32 - which contained several bug fixes.
Had to back off from making the xgrid the default - since this caused an ESMF error in generating the second order conservative mapping (see #7)
Contributors other than yourself, if any: None
CMEPS Issues Fixed: None
Are changes expected to change answers? No
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Ran the following case on betzy
--compset 2000_CAM60_CLM50%SP_CICE_BLOM_MOSART_SGLC_WW3DEV_SESP --res f19_tn14_wtn14