Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making preformed tracers optional to enable HR runs without them #394

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Sep 9, 2024

@JorgSchwinger and @TomasTorsvik , as suggested in #340 , preformed tracers could be made optional to enable HR runs without them. With this PR, this is achieved, while the default is still to run iHAMOCC with preformed tracers.

@matsbn , the new introduced switch use_pref_tracers via xmlchange HAMOCC_PREF_TRACERS=FALSE might be of interest for you, in the case that you want to run HR simulations including iHAMOCC, while wanting to reduce the BGC costs.

Run with preformed tracers enabled by default
@jmaerz jmaerz added enhancement New feature or request iHAMOCC Issue mainly concerns the iHAMOCC code base labels Sep 9, 2024
@jmaerz jmaerz added this to the NorESM2.5 - BLOM/iHAMOCC milestone Sep 9, 2024
@jmaerz jmaerz self-assigned this Sep 9, 2024
Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I'm not sure the special treatment for preformed silicate during restart is necessary. See my comment in the code

<default_value>TRUE</default_value>
<group>run_component_blom</group>
<file>env_run.xml</file>
<desc>Set preprocessor option to activate the preformed tracer code. Requires module ecosys</desc>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest replacing "preprocessor" by "namelist"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

call read_netcdf_var(ncid,'prefdic',locetra(1,1,1,iprefdic),2*kpke,0,iotype)
if(lread_prefsi) then
call read_netcdf_var(ncid,'prefsilica',locetra(1,1,1,iprefsilica),2*kpke,0,iotype)
endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the preformed silicate is treated differently from the other preformed tracers? Does it make sense to have the capability to restart with a preformed tracer when it is not in the restart file only for silicate but not for the others? I do not see so many use cases for this so maybe we can just omit the lread_prefsi related code?

Copy link
Collaborator Author

@jmaerz jmaerz Sep 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jörg, since preformed silicate wasn't in the restart files before, start-up from restart files was an issue, hence this little quirky treatment that was put in to enable running the model from a restart file without it. Once we settle with #356 or have enough spun-up restart files with preformed silicate, this won't be an issue any longer and it can be removed. Hence, I would keep this treatment for now. We can put this clean-up task into #340 (and #356).

Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaerz - Thanks, looks fine from my side.

@jmaerz
Copy link
Collaborator Author

jmaerz commented Sep 10, 2024

@JorgSchwinger , any further comments or can I merge?

@JorgSchwinger
Copy link
Contributor

Please go ahead!

@jmaerz jmaerz merged commit 96089fa into NorESMhub:master Sep 10, 2024
5 checks passed
@jmaerz jmaerz deleted the ihamocc_opt-pref branch September 10, 2024 14:59
@jmaerz jmaerz mentioned this pull request Sep 12, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants