Fix validation failing when there's a hh3 cache hit #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #715 +/- ##
===============================================
+ Coverage 52.61% 52.93% +0.32%
===============================================
Files 231 231
Lines 5592 5728 +136
Branches 878 918 +40
===============================================
+ Hits 2942 3032 +90
- Misses 2392 2427 +35
- Partials 258 269 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I think this is only part of the problem, because the logs seem to indicate that something else is going off. Look at this. New project, viem sample project. I open the first Solidity file. I get this log: I close the file, clear the log, Some part of the language server is treating |
Collaborator
Author
|
@alcuadrado good catch, just pushed a commit to fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you compile a hardhat3 project, cache entries will be set for the contracts that were compiled successfully. When attempting validation for a file,
getCompilationJobsis used, which returns an empty array if there are no jobs to compile (because there was a cache hit). Two possible options would be to either skip validation when there are no jobs to compile, or to passforce: true. I chose the latter one since I think it's consistent with our model of compiling on every file change.