Skip to content

fix(vis-network): unit tests #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErwanRaulo
Copy link
Contributor

@ErwanRaulo ErwanRaulo commented Jun 30, 2025

Adapt unit tests and fixture to current implementation of dataset.

i need advice on unknown license computation, i removed their test because current algorithm does handle this case, for example :

  • "license": "a string licence (should be unknown)"
  • will not give {unknown: 1}
  • because computeLicense fn expects an iterable and a string is an iterable so the number of licenses will be the number of characters.

does unknown license is buggy or not handled anymore ?

@ErwanRaulo ErwanRaulo force-pushed the fix/vis-network-tests branch 6 times, most recently from 7a36885 to 411fb76 Compare July 8, 2025 19:50
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.15%. Comparing base (28ee6a9) to head (11956fc).
Report is 209 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##            master     #528       +/-   ##
============================================
- Coverage   100.00%   59.15%   -40.85%     
============================================
  Files           15       38       +23     
  Lines          649     2921     +2272     
  Branches         0       14       +14     
============================================
+ Hits           649     1728     +1079     
- Misses           0     1193     +1193     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants