Move channels to tarballs - #100
Conversation
GraysonTinker
left a comment
GraysonTinker
left a comment
There was a problem hiding this comment.
LGTM (I came here to do the same thing), but we should probably recommend the .tar.zst files that are now available.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/psa-use-nixos-org-tarballs-for-your-flake-inputs/79950/27 |
|
Pushed a change to swap to |
|
Added the tarball to the "full" template but it isn't being used. At least it is there as an example I guess. |
|
Thanks! |
|
|
||
| # Nixpkgs / NixOS version to use. | ||
| inputs.nixpkgs.url = "nixpkgs/nixos-21.11"; | ||
| inputs.nixpkgs.url = "https://channels.nixos.org/nixos-21.11/nixexprs.tar.zst"; |
There was a problem hiding this comment.
Eh, this is wrong. 21.11 doesn't have zstd tarballs, this won't work. Those are only for the newer channels like 26.05 and unstable - the non-EOL ones.
But also, surely the templates should be updated to non-EOL nixpkgs? But that will require quite a bit of work.
There was a problem hiding this comment.
My bad, should've noticed and checked this!
The vendorHash, Go version bump, and nixpkgs pin from NixOS#92 were already fixed on master by NixOS#89, NixOS#100, and NixOS#105; this lands the one still- relevant piece of that PR: dropping the deprecated defaultPackage output in favor of packages.default, matching the pattern already used by c-hello and rust-web-server. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The vendorHash, Go version bump, and nixpkgs pin from #92 were already fixed on master by #89, #100, and #105; this lands the one still- relevant piece of that PR: dropping the deprecated defaultPackage output in favor of packages.default, matching the pattern already used by c-hello and rust-web-server. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
5 participants
See this thread for full context.
TL:DR; the channel tarballs are actually ahead of the GitHub and with the lockable tarball protocol being a thing, they should probably be used.
This PR also removes a URL literal in
rust-web-serverwhich have been deprecated.I'm not certain what to do with
fullthough.TO-DO
github:tochannels.nixos.org.nixpkgsfrom the registry (as these also link to GitHub).full, should it be moved over to the channel tarballs or have an example of it at least?