-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the beta phase #42
Conversation
# Beta Phase | ||
|
||
- Monitor the master branch for bugfixes and minor updates and | ||
cherry-pick them to the release branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I forgot is NixOS/nixpkgs#173671 but I don't really know how to phrase this and when to do it. Do you have any idea, @Mindavi? You starting around the time of branch-off is probably good to get done in time. Also related to #4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past, I believe this has been done one evaluation before official release, but I may be mistaken. That way ZHF fixes can be accepted until the very last second.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it makes sense to do it at the very last moment. Would be nice if we could get a script or something going, but it seems like that might be some more work than I have time for now.
I think it could make sense to just mark them all and then drop any commits that are not applicable anymore.
But yeah, definitely figuring out the process myself too. Any process description is probably better than none :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/NixOS/nixpkgs/blob/master/pkgs/common-updater/scripts/mark-broken looks like it should help with / do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, could definitely be useful! (Though it doesn't take into account different platforms, but we may be able to build that easily-ish 😁)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mweinelt, @vcunat, @cole-h because you reviewed my last PR as well.
Maybe there's something to mention that I forgot? I don't plan to merge this until 1-2 days before the release