haskellPackages.http2-client: fix bounds #375138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternenseemann
requested changes
Jan 20, 2025
| http2-client = overrideCabal (drv: { | ||
| patches = drv.patches or [ ] ++ [ | ||
| (pkgs.fetchpatch { | ||
| url = "https://patch-diff.githubusercontent.com/raw/haskell-grpc-native/http2-client/pull/96.patch"; |
There was a problem hiding this comment.
Please use a patch url that includes the commit hash so the patch is at least somewhat reproducible: https://github.com/haskell-grpc-native/http2-client/commit/952a57d1138dc31863a5e387dbda67cbdfcfd9f4.patch
Also, it is good practice to give the patch a meaninful name, so it's clear what it does in the build output.
There was a problem hiding this comment.
thanks, good points, just fixed 👍
mpscholten
force-pushed
the
http2-client-fix
branch
from
ddd69d6 to
752dc58
Compare
|
Have you tried the |
mpscholten
force-pushed
the
http2-client-fix
branch
from
752dc58 to
d2712b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Fixes https://hydra.nixos.org/build/285294584/nixlog/1
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.