Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sirula: 1.0.0-unstable to 1.1.0 #371977

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

atagen
Copy link

@atagen atagen commented Jan 8, 2025

Things done

  • updated source to 1.1.0
  • updated Cargo.lock
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 8, 2025
Copy link
Contributor

@l1npengtul l1npengtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of pname binding here is discouraged.

pkgs/by-name/si/sirula/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/si/sirula/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/si/sirula/package.nix Outdated Show resolved Hide resolved
@atagen
Copy link
Author

atagen commented Jan 8, 2025

depends on #372016 now for maintainer update

@l1npengtul
Copy link
Contributor

You can add yourself to maintainers in the same PR, just make sure the commit that touches the maintainers file comes before the commit that changes the package.

@l1npengtul
Copy link
Contributor

l1npengtul commented Jan 8, 2025

Also, the package isn't formatted properly. Please make sure you are using nixfmt, as alejandra is not RFC compliant (I know from experience).

Here is the diff for reference:

-{ nix-update-script, lib, fetchFromGitHub, rustPlatform, pkg-config, gtk3
-, gtk-layer-shell, }:
+{
+  nix-update-script,
+  lib,
+  fetchFromGitHub,
+  rustPlatform,
+  pkg-config,
+  gtk3,
+  gtk-layer-shell,
+}:
 rustPlatform.buildRustPackage {
   pname = "sirula";
   version = "1.1.0";
@@ -13,14 +20,16 @@ rustPlatform.buildRustPackage {
   cargoLock = {
     lockFile = ./Cargo.lock;
     outputHashes = {
-      "osstrtools-0.2.2" =
-        "sha256-Co4pcikfN4vtIVK7ZsRGCWMAhMJWNNVZe/AdN1nMlmQ=";
+      "osstrtools-0.2.2" = "sha256-Co4pcikfN4vtIVK7ZsRGCWMAhMJWNNVZe/AdN1nMlmQ=";
     };
   };
 
   nativeBuildInputs = [ pkg-config ];
 
-  buildInputs = [ gtk3 gtk-layer-shell ];
+  buildInputs = [
+    gtk3
+    gtk-layer-shell
+  ];
 
   passthru.updateScript = nix-update-script { };

@atagen
Copy link
Author

atagen commented Jan 8, 2025

oh well, it's needed across a few PRs for me to become maintainer, better not to pin it to any one of them

@atagen
Copy link
Author

atagen commented Jan 8, 2025

Also, the package isn't formatted properly. Please make sure you are using nixfmt, as alejandra is not RFC compliant (I know from experience).

I use it like , nixfmt pkgs/by-name/si/sirula/package.nix, maybe comma is not using nixfmt-rfc-style for this but nixfmt-classic or something?

@l1npengtul
Copy link
Contributor

Also, the package isn't formatted properly. Please make sure you are using nixfmt, as alejandra is not RFC compliant (I know from experience).

I use it like , nixfmt pkgs/by-name/si/sirula/package.nix, maybe comma is not using nixfmt-rfc-style for this but nixfmt-classic or something?

Thats odd, should be the correct usage...
Perhaps try using nix-shell -p nixfmt-rfc-style to ensure you're getting the correct one?

@l1npengtul
Copy link
Contributor

l1npengtul commented Jan 8, 2025

oh well, it's needed across a few PRs for me to become maintainer, better not to pin it to any one of them

Ah, ok.

@l1npengtul l1npengtul added 8.has: package (update) This PR updates a package to a newer version 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 9.needs: maintainer Package or module needs active maintainers and removed 9.needs: maintainer Package or module needs active maintainers 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Jan 8, 2025
Copy link
Contributor

@l1npengtul l1npengtul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format this file again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants