Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver-bin: 24.3.0 -> 24.3.1 #370248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Jan 2, 2025

Release: https://github.com/dbeaver/dbeaver/releases/tag/24.3.1

error: auto-patchelf could not satisfy dependency libc.so.8 wanted by /nix/store/ab3h9jijfkia59ia1bnncaz6yx43l2rb-dbeaver-bin-24.3.1/opt/dbeaver/plugins/com.sun.jna_5.15.0.v20240915-2000/com/sun/jna/dragonflybsd-x86-64/libjnidispatch.so

I couldn't find a libc.so.8 library with nix-locate or on the internet so I made autopatchelf ignore it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gepbird
Copy link
Contributor Author

gepbird commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370248


x86_64-linux

✅ 1 package built:
  • dbeaver-bin

(the failing check is unrelated to this PR, see #355847 (comment))

@gepbird gepbird requested review from mkg20001 and yzx9 January 2, 2025 14:29
Copy link
Contributor

@yzx9 yzx9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


1 package built:
dbeaver-bin

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370248


aarch64-darwin

✅ 1 package built:
  • dbeaver-bin

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants