You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
Tests seem to hang forever on aarch64-linux.
Maybe set doCheck = !(stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64) with a comment saying this.
The test failed with an GitHub Actions has encountered an internal error when running your job. and seems to have passed now, so probably a transient error. Nothing i should need to work around.
The test failed with an GitHub Actions has encountered an internal error when running your job. and seems to have passed now, so probably a transient error. Nothing i should need to work around.
Well, when I try to build it locally on aarch64-linux, it hangs indefinitely here:
Seems like the test was introduced in 97724a424116e4401ac8da7878699885352c46ac. Disabling the test seems like a non-solution to me. I'd rather mark it as broken for aarch64-linux as that test demonstrates that the functionality is broken.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zimward
added
8.has: package (update)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.