PyKMS maintenance: unstable-2021-01-25 -> 0-unstable-2024-07-06 #369724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
github-actions
bot
added
10.rebuild-darwin: 0
zopieux
approved these changes
Jan 1, 2025
wegank
added
the
12.approvals: 1
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-369724-to-release-24.11 origin/release-24.11
cd .worktree/backport-369724-to-release-24.11
git switch --create backport-369724-to-release-24.11
git cherry-pick -x e162494ac40ce637fd5cdcb87a83038255ed6abc 0826de34a5452a77edb56aadbed7f0574af55009 92242097202b12f1224481f5d71ec6348eb34843 |
|
Backporting: the pykms installation I run on 24.11 is effectively broken since it also has the issue you linked above. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using Python 3.12 by default, which breaks the current version of PyKMS. Update with the HEAD of
nextbranch since the fix is only available there.Also added a trivial
packageoption to allow overriding default pykms package, and provided a dual stack binding example.Dogfooding
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.