Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.tree-sitter: fix failing test #369669

Closed
wants to merge 1 commit into from
Closed

python3Packages.tree-sitter: fix failing test #369669

wants to merge 1 commit into from

Conversation

eljamm
Copy link
Contributor

@eljamm eljamm commented Dec 31, 2024

Closes #369515

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@eljamm
Copy link
Contributor Author

eljamm commented Dec 31, 2024

@ofborg build python3Packages.tree-sitter

@eljamm
Copy link
Contributor Author

eljamm commented Dec 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369669

x86_64-linux

⏩ 80 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python312Packages.grep-ast
  • python312Packages.grep-ast.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-readers-database
  • python312Packages.llama-index-readers-database.dist
  • python312Packages.llama-index-readers-file
  • python312Packages.llama-index-readers-file.dist
  • python312Packages.llama-index-readers-json
  • python312Packages.llama-index-readers-json.dist
  • python312Packages.llama-index-readers-llama-parse
  • python312Packages.llama-index-readers-llama-parse.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.llama-index-readers-twitter
  • python312Packages.llama-index-readers-twitter.dist
  • python312Packages.llama-index-readers-txtai
  • python312Packages.llama-index-readers-txtai.dist
  • python312Packages.llama-index-readers-weather
  • python312Packages.llama-index-readers-weather.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-index.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
  • python312Packages.tree-sitter-languages
  • python312Packages.tree-sitter-languages.dist
  • python313Packages.grep-ast
  • python313Packages.grep-ast.dist
  • python313Packages.tree-sitter-languages
  • python313Packages.tree-sitter-languages.dist
  • zeekscript
  • zeekscript.dist
❌ 22 packages failed to build:
  • harlequin
  • harlequin.dist
  • memray
  • memray.dist
  • python313Packages.lsp-tree-sitter
  • python313Packages.lsp-tree-sitter.dist
  • python313Packages.manifestoo
  • python313Packages.manifestoo.dist
  • python313Packages.pytest-textual-snapshot
  • python313Packages.pytest-textual-snapshot.dist
  • python313Packages.textual
  • python313Packages.textual-dev
  • python313Packages.textual-dev.dist
  • python313Packages.textual-fastdatatable
  • python313Packages.textual-fastdatatable.dist
  • python313Packages.textual-slider
  • python313Packages.textual-slider.dist
  • python313Packages.textual-textarea
  • python313Packages.textual-textarea.dist
  • python313Packages.textual-universal-directorytree
  • python313Packages.textual-universal-directorytree.dist
  • python313Packages.textual.dist
✅ 51 packages built:
  • browsr
  • browsr.dist
  • codecov-cli
  • codecov-cli.dist
  • dooit
  • dooit-extras
  • dooit-extras.dist
  • dooit.dist
  • frogmouth
  • frogmouth.dist
  • isponsorblocktv
  • isponsorblocktv.dist
  • mutmut
  • mutmut.dist
  • oterm
  • oterm.dist
  • python312Packages.lsp-tree-sitter
  • python312Packages.lsp-tree-sitter.dist
  • python312Packages.manifestoo
  • python312Packages.manifestoo.dist
  • python312Packages.pytest-textual-snapshot
  • python312Packages.pytest-textual-snapshot.dist
  • python312Packages.textual
  • python312Packages.textual-dev
  • python312Packages.textual-dev.dist
  • python312Packages.textual-fastdatatable
  • python312Packages.textual-fastdatatable.dist
  • python312Packages.textual-slider
  • python312Packages.textual-slider.dist
  • python312Packages.textual-textarea
  • python312Packages.textual-textarea.dist
  • python312Packages.textual-universal-directorytree
  • python312Packages.textual-universal-directorytree.dist
  • python312Packages.textual.dist
  • python312Packages.tree-sitter
  • python312Packages.tree-sitter.dist
  • python313Packages.tree-sitter
  • python313Packages.tree-sitter.dist
  • rich-cli
  • rich-cli.dist
  • smassh
  • smassh.dist
  • streamcontroller
  • tftui
  • tftui.dist
  • toolong
  • toolong.dist
  • upiano
  • upiano.dist
  • wsrepl
  • wsrepl.dist

@ofborg ofborg bot requested a review from fabaff December 31, 2024 15:42
@fabaff
Copy link
Member

fabaff commented Jan 1, 2025 •
edited
Loading 

[...]
       > Check whether the following modules can be imported: tree_sitter
       > Running phase: pytestCheckPhase
       > Executing pytestCheckPhase
       > substituteStream() in derivation python3.13-tree-sitter-0.23.2: ERROR: pattern 2795 doesn't match anything in file 'tests/test_language.py'
       For full logs, run 'nix log /nix/store/rkhyvxza2n69g6df7hibm9zy1rmlsvkc-python3.13-tree-sitter-0.23.2.drv'.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 369669

x86_64-linux

⏩ 80 packages marked as broken and skipped:
  • private-gpt
  • private-gpt.dist
  • python312Packages.grep-ast
  • python312Packages.grep-ast.dist
  • python312Packages.llama-index
  • python312Packages.llama-index-agent-openai
  • python312Packages.llama-index-agent-openai.dist
  • python312Packages.llama-index-cli
  • python312Packages.llama-index-cli.dist
  • python312Packages.llama-index-core
  • python312Packages.llama-index-core.dist
  • python312Packages.llama-index-embeddings-gemini
  • python312Packages.llama-index-embeddings-gemini.dist
  • python312Packages.llama-index-embeddings-google
  • python312Packages.llama-index-embeddings-google.dist
  • python312Packages.llama-index-embeddings-huggingface
  • python312Packages.llama-index-embeddings-huggingface.dist
  • python312Packages.llama-index-embeddings-ollama
  • python312Packages.llama-index-embeddings-ollama.dist
  • python312Packages.llama-index-embeddings-openai
  • python312Packages.llama-index-embeddings-openai.dist
  • python312Packages.llama-index-graph-stores-nebula
  • python312Packages.llama-index-graph-stores-nebula.dist
  • python312Packages.llama-index-graph-stores-neo4j
  • python312Packages.llama-index-graph-stores-neo4j.dist
  • python312Packages.llama-index-graph-stores-neptune
  • python312Packages.llama-index-graph-stores-neptune.dist
  • python312Packages.llama-index-indices-managed-llama-cloud
  • python312Packages.llama-index-indices-managed-llama-cloud.dist
  • python312Packages.llama-index-legacy
  • python312Packages.llama-index-legacy.dist
  • python312Packages.llama-index-llms-ollama
  • python312Packages.llama-index-llms-ollama.dist
  • python312Packages.llama-index-llms-openai
  • python312Packages.llama-index-llms-openai-like
  • python312Packages.llama-index-llms-openai-like.dist
  • python312Packages.llama-index-llms-openai.dist
  • python312Packages.llama-index-multi-modal-llms-openai
  • python312Packages.llama-index-multi-modal-llms-openai.dist
  • python312Packages.llama-index-program-openai
  • python312Packages.llama-index-program-openai.dist
  • python312Packages.llama-index-question-gen-openai
  • python312Packages.llama-index-question-gen-openai.dist
  • python312Packages.llama-index-readers-database
  • python312Packages.llama-index-readers-database.dist
  • python312Packages.llama-index-readers-file
  • python312Packages.llama-index-readers-file.dist
  • python312Packages.llama-index-readers-json
  • python312Packages.llama-index-readers-json.dist
  • python312Packages.llama-index-readers-llama-parse
  • python312Packages.llama-index-readers-llama-parse.dist
  • python312Packages.llama-index-readers-s3
  • python312Packages.llama-index-readers-s3.dist
  • python312Packages.llama-index-readers-twitter
  • python312Packages.llama-index-readers-twitter.dist
  • python312Packages.llama-index-readers-txtai
  • python312Packages.llama-index-readers-txtai.dist
  • python312Packages.llama-index-readers-weather
  • python312Packages.llama-index-readers-weather.dist
  • python312Packages.llama-index-vector-stores-chroma
  • python312Packages.llama-index-vector-stores-chroma.dist
  • python312Packages.llama-index-vector-stores-google
  • python312Packages.llama-index-vector-stores-google.dist
  • python312Packages.llama-index-vector-stores-postgres
  • python312Packages.llama-index-vector-stores-postgres.dist
  • python312Packages.llama-index-vector-stores-qdrant
  • python312Packages.llama-index-vector-stores-qdrant.dist
  • python312Packages.llama-index.dist
  • python312Packages.llama-parse
  • python312Packages.llama-parse.dist
  • python312Packages.private-gpt
  • python312Packages.private-gpt.dist
  • python312Packages.tree-sitter-languages
  • python312Packages.tree-sitter-languages.dist
  • python313Packages.grep-ast
  • python313Packages.grep-ast.dist
  • python313Packages.tree-sitter-languages
  • python313Packages.tree-sitter-languages.dist
  • zeekscript
  • zeekscript.dist
❌ 73 packages failed to build:
  • browsr
  • browsr.dist
  • codecov-cli
  • codecov-cli.dist
  • dooit
  • dooit-extras
  • dooit-extras.dist
  • dooit.dist
  • frogmouth
  • frogmouth.dist
  • harlequin
  • harlequin.dist
  • isponsorblocktv
  • isponsorblocktv.dist
  • memray
  • memray.dist
  • mutmut
  • mutmut.dist
  • oterm
  • oterm.dist
  • python312Packages.lsp-tree-sitter
  • python312Packages.lsp-tree-sitter.dist
  • python312Packages.manifestoo
  • python312Packages.manifestoo.dist
  • python312Packages.pytest-textual-snapshot
  • python312Packages.pytest-textual-snapshot.dist
  • python312Packages.textual
  • python312Packages.textual-dev
  • python312Packages.textual-dev.dist
  • python312Packages.textual-fastdatatable
  • python312Packages.textual-fastdatatable.dist
  • python312Packages.textual-slider
  • python312Packages.textual-slider.dist
  • python312Packages.textual-textarea
  • python312Packages.textual-textarea.dist
  • python312Packages.textual-universal-directorytree
  • python312Packages.textual-universal-directorytree.dist
  • python312Packages.textual.dist
  • python312Packages.tree-sitter
  • python312Packages.tree-sitter.dist
  • python313Packages.lsp-tree-sitter
  • python313Packages.lsp-tree-sitter.dist
  • python313Packages.manifestoo
  • python313Packages.manifestoo.dist
  • python313Packages.pytest-textual-snapshot
  • python313Packages.pytest-textual-snapshot.dist
  • python313Packages.textual
  • python313Packages.textual-dev
  • python313Packages.textual-dev.dist
  • python313Packages.textual-fastdatatable
  • python313Packages.textual-fastdatatable.dist
  • python313Packages.textual-slider
  • python313Packages.textual-slider.dist
  • python313Packages.textual-textarea
  • python313Packages.textual-textarea.dist
  • python313Packages.textual-universal-directorytree
  • python313Packages.textual-universal-directorytree.dist
  • python313Packages.textual.dist
  • python313Packages.tree-sitter
  • python313Packages.tree-sitter.dist
  • rich-cli
  • rich-cli.dist
  • smassh
  • smassh.dist
  • streamcontroller
  • tftui
  • tftui.dist
  • toolong
  • toolong.dist
  • upiano
  • upiano.dist
  • wsrepl
  • wsrepl.dist

@pcboy
Copy link
Contributor

pcboy commented Jan 1, 2025

FYI, the harlequin package is currently broken on master as it's not compatible with the version of textual present on master. #365766

Fixing the build of tree-sitter and textual will help though. As since they broke that MR started to fail too.

@eljamm
Copy link
Contributor Author

eljamm commented Jan 1, 2025

I'm closing this PR since the same change was merged in #369190, which also fixes tree-sitter.

@eljamm eljamm closed this Jan 1, 2025
@eljamm eljamm deleted the tree-sitter branch January 1, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff Awaiting requested review from fabaff

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: python3Packages.tree-sitter-0.23.2
3 participants
@eljamm @fabaff @pcboy