-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cross build for various python packages #369631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
- The changes to bcrypt look fine
- The changes to contourpy need work, they break the test suite and Python 3.13 support
- For the home-assistant-chip-wheels changes I'd like @symphorien to also take a look
All changes except for chip-wheels need to pass through staging, because they're too stronk.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regresses #355051
I'm surprised you could cross compile chip at all. The list of python dependencies mixes build and runtime dependencies. Also TIL about genricClosure, thanks. |
Fixed
Hm, not sure. At least it does build now. We can still push more fixes later in case it doesn't work in practice. I don't use matter as of now. Another weird thing is, when evaluating chip for a cross system, it takes very long and uses around 50GB or ram. I had to enable zram in order to build it. I wonder if such performance impact is expected because of cross, or if this has to do with this manual dependency juggling going on here. |
About the egregious memory use when cross building: I commented out all attributes of stdenv.mkDerivation except name and version and got the same issue, so the memory issue does not come from the computation you replaced by genericClosure. |
The cause of the excessive memory usage for cross python is known, but I have no idea how to resolve this. |
Apart from the cross fixes, this contains an optimization for the dependency closure computation in
home-assistant-chip-wheels
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.