-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos: hardware.pulseaudio → services.pulseaudio #369391
Conversation
|
Thanks for the swift review, @fpletz ! ❤️ |
Such cleanups are always appreciated. 😸 I didn't merge right away because I wanted to let this sit for a few days to see if anybody else has any opinions on this. Shouldn't be that controversial, though, so no worries you merged this already. 👍 |
Ah, sorry, it was so uncontrovertial I thought we were both waiting on CI 😅 (in addition to at least 1 review, of course) |
For some reason, Yes, I'm tracking master as I try to fix my flake from all the package failures :P |
Oy vey 😓
And we thank you for stepping on all the rakes and reporting them ❤️ |
Rename the
hardware.pulseaudio
options toservices.pulseaudio
.This is more consistent, considering:
pulseaudio
can be used without local audio hardware, nor is it necessary to use said hardware ;jack
andpipewire
are underservices
.Things done
nixosTests.pulseaudio
python3Packages.soundcard.tests
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usageAdd a 👍 reaction to pull requests you find important.