genemichaels: apply patch to only write files if changed #365303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When formatting rust files with `genemichaels`, the timestamp of the file is always modified whether or not the file was changed. This is problematic for detecting whether a file has been reformatted or not, such as when using tools such as `pre-commit`, `treefmt`, and `treefmt-nix`. See the following: andrewbaxter/genemichaels#95 andrewbaxter/genemichaels#96 numtide/treefmt-nix#277
|
Result of 1 package built:
|
ofborg
bot
added
11.by: package-maintainer
|
Looks like the patch was merged and included in the latest tag! Can we bump that in this PR? |
getchoo
reviewed
Dec 17, 2024
| # bumped to a release that has this change | ||
| # See: https://github.com/andrewbaxter/genemichaels/issues/95 | ||
| # See: https://github.com/andrewbaxter/genemichaels/pull/96 | ||
| ./genemichaels-only-write-if-changed.patch |
There was a problem hiding this comment.
It'd be better to fetch the patch from GitHub rather than vendoring it in-tree
Suggested change
| ./genemichaels-only-write-if-changed.patch | |
| (fetchpatch { | |
| url = "https://github.com/andrewbaxter/genemichaels/commit/3c58f090888053b5165dbb0292b5974293851e2a.patch"; | |
| hash = "sha256-vxtO9N6P6rcfGhIfagr2fT83o0lM6J1tOckxarMJkL8="; | |
| }) |
Or update, oops! |
|
I didn't expect them to merge my PR so quickly. I'll make a new PR to bump the version and close this. |
|
Closing in favor of #365966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatting rust files with
genemichaels, the timestamp of the file is always modified whether or not the file was changed. This is problematic for detecting whether a file has been reformatted or not, such as when using tools such aspre-commit,treefmt, andtreefmt-nix.See the following:
andrewbaxter/genemichaels#95
andrewbaxter/genemichaels#96
numtide/treefmt-nix#277
Things done
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.