-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libsoup_2_4: Rename from libsoup #360908
libsoup_2_4: Rename from libsoup #360908
Conversation
f94325a
to
c25efef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr touches hackage-packages.nix
Not much we can do about that if we do not want to break eval without aliases. Well, we could place the alias to |
Well, we have to do something about it. I see two options: Either add overrides for these packages in configuration-nix.nix or in cabal2nix. I assume @sternenseemann has an opinion on what’s right here. I mean in theory we don’t even know if the Haskell packages build with the newer libsoup. |
It is not a new version, only the attribute name changed. |
We should probably do the same as we did with the attribute name rename of webkitgtk:
|
`pkgconfig-depends: libsoup-3.0` was being incorrectly resolved to `libsoup` attribute. Additionally, NixOS/nixpkgs#360908 renamed `libsoup` attribute to `libsoup_2_4`. Let’s use the correct package attribute names for all libsoup pkg-config files. All libsoup dependent Haskell-packages use `pkgconfig-depends` with one of those names: https://hackage.haskell.org/package/gi-soup-3.0.3/src/gi-soup.cabal https://hackage.haskell.org/package/gi-soup-2.4.29/src/gi-soup.cabal https://hackage.haskell.org/package/spike-0.3/src/spike.cabal
c25efef
to
70bd781
Compare
Opened NixOS/cabal2nix#635 Edit: Rebased and added |
70bd781
to
edeadb7
Compare
edeadb7
to
2476dd6
Compare
I've added the |
It is unused since 4.5.0: quodlibet/quodlibet@b973220
WebKitGTK 4.1 ABI requires libsoup 3.0. It probably only worked because `webkitgtk_4_1` propagates `libsoup_3` and we were lucky that that version got picked up.
WebKitGTK 4.1 ABI requires libsoup 3.0. It probably only worked because `webkitgtk_4_1` propagates `libsoup_3` and we were lucky that that version got picked up.
WebKitGTK 4.1 ABI requires libsoup 3.0. It probably only worked because `webkitgtk_4_1` propagates `libsoup_3` and we were lucky that that version got picked up.
WebKitGTK 4.1 ABI requires libsoup 3.0. It probably only worked because `webkitgtk_4_1` propagates `libsoup_3` and we were lucky that that version got picked up.
libsoup 2.4 is actually not using this library, only libsoup_3 is.
No-one should be using gnome2 nowadays.
2476dd6
to
1d69811
Compare
This emits versioned libsoup_* attributes in hackage-packages.nix and (unrelatedly) adds support for opencascade-*, thus closes NixOS#359831.
The 2.4 ABI branch has not been supported by upstream for a while now but people still keep accidentally adding it to new packages.
1d69811
to
93558e0
Compare
The
Can we remove the |
The 2.4 ABI branch has not been supported by upstream for a while now but people still keep accidentally adding it to new packages.
See #360897
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.