Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.gensim: get src from repo, unpin cython_0 #353367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Nov 3, 2024

Follow up to #352711.
Fixes gensim for Python 3.12.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lblasc
Copy link
Contributor

lblasc commented Nov 4, 2024

I can confirm that it builds fine locally with python 3.12.

closes #352593

thank you @tobim !

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 4, 2024
lblasc pushed a commit to tvbeat/nixpkgs that referenced this pull request Nov 4, 2024
lblasc pushed a commit to tvbeat/nixpkgs that referenced this pull request Nov 6, 2024
@FliegendeWurst
Copy link
Member

Please replace numpy with numpy_1, the default will soon be 2.x.

Related piskvorky/gensim#3560

kmein added a commit to kmein/niveum that referenced this pull request Dec 16, 2024
@tobim tobim force-pushed the pkgs/gensim-python312 branch from 7b3c1bb to c69bccb Compare December 17, 2024 08:02
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 18, 2024
@FliegendeWurst
Copy link
Member

Oh, unfortunately that is not enough. gensim depends on scipy, which already updated to numpy 2 in staging-next. And it is no longer compatible with numpy 1.x.

The upstream upgrade to Numpy 2 piskvorky/gensim#3563 seems to be progressing slowly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants