-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.gensim: get src from repo, unpin cython_0 #353367
Open
tobim
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
tobim:pkgs/gensim-python312
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Nov 4, 2024
lblasc
pushed a commit
to tvbeat/nixpkgs
that referenced
this pull request
Nov 4, 2024
lblasc
approved these changes
Nov 4, 2024
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 4, 2024
lblasc
pushed a commit
to tvbeat/nixpkgs
that referenced
this pull request
Nov 4, 2024
lblasc
pushed a commit
to tvbeat/nixpkgs
that referenced
this pull request
Nov 6, 2024
Please replace numpy with numpy_1, the default will soon be 2.x. Related piskvorky/gensim#3560 |
kmein
added a commit
to kmein/niveum
that referenced
this pull request
Dec 16, 2024
tobim
force-pushed
the
pkgs/gensim-python312
branch
from
December 17, 2024 08:02
7b3c1bb
to
c69bccb
Compare
wegank
removed
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Dec 18, 2024
Oh, unfortunately that is not enough. gensim depends on scipy, which already updated to numpy 2 in staging-next. And it is no longer compatible with numpy 1.x. The upstream upgrade to Numpy 2 piskvorky/gensim#3563 seems to be progressing slowly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: python
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #352711.
Fixes gensim for Python 3.12.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.