Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

viewnior: switch to gtk3 PR #349819

Merged
merged 3 commits into from
Oct 21, 2024
Merged

viewnior: switch to gtk3 PR #349819

merged 3 commits into from
Oct 21, 2024

Conversation

Artturin
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Artturin Artturin mentioned this pull request Oct 19, 2024
Merged
13 tasks
@Aleksanaa
Copy link
Member

hellosiyan/Viewnior#108 (comment) is this patch needed?

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 19, 2024
@Artturin Artturin force-pushed the viewniorgtk3 branch 2 times, most recently from fe3ce93 to 9fe80c4 Compare October 19, 2024 20:20
@Artturin
viewnior: add webp support
40a4bd0 
and fix

```
(viewnior:2739789): Gtk-WARNING **: 23:12:19.403: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.
```
@Artturin
viewnior: Use x11
e547a1f
@Aleksanaa Aleksanaa merged commit a5e6a9e into NixOS:master Oct 21, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artturin @Aleksanaa