python312Packages.deepdiff: 7.0.1 -> 8.0.1 #348567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
08d8fb2 to
57d3c21
Compare
ofborg
bot
added
11.by: package-maintainer
|
natsukium
reviewed
Oct 16, 2024
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
57d3c21 to
5ebdc41
Compare
|
I fixed (hopefully all) direct dependents of deepdiff. Let's see how smaller the nixpkgs-review failure list will be now. |
ofborg
bot
requested review from
fabaff,
dotlambda,
jbaum98,
sumnerevans and
albakham
|
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
20a3725 to
972ee2e
Compare
|
OK Great the dbt failures are not new failure, e.g: https://hydra.nixos.org/build/274882178 I'm not going to fix that as it is unrelated to this update. The maintainers of these packages will become aware of these failures at some point. Will let ofborg ping the maintainers and will wait a day or two, and will merge afterwards if no objections arise. |
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
972ee2e to
8868ee4
Compare
|
Rebased after a merge conflict (it seems someone has fixed an issue with |
|
We should be able to get rid of numpy by updating deepdiff to 8.0.1: seperman/deepdiff#479 |
|
OK, upstream is communicative (e.g seperman/deepdiff#496 ). |
dotlambda
reviewed
Oct 23, 2024
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
8868ee4 to
93c8848
Compare
|
Also removed the |
doronbehar
changed the title
Not yet fully building, but with a Python package set that uses protobuf4 instead of protobuf5, it is working.
doronbehar
force-pushed
the
pkg/python-deepdiff
branch
from
93c8848 to
e5a2d54
Compare
|
Fixed the 8.0.1 tagging issue after upstream fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.