Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beszel: init at 0.6.2 #345444

Merged
merged 1 commit into from
Nov 10, 2024
Merged

beszel: init at 0.6.2 #345444

merged 1 commit into from
Nov 10, 2024

Conversation

Bot-wxt1221
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 commented Sep 30, 2024

Description of changes

Fix #345389

package-lock.json: henrygd/beszel#192

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@afh
Copy link
Member

afh commented Oct 2, 2024

Result of nixpkgs-review pr 345444 run on aarch64-darwin 1

1 package failed to build:
  • beszel

See beszel-0.5.0-error.log for details

@mirkolenz
Copy link
Member

mirkolenz commented Oct 2, 2024

Result of nixpkgs-review pr 345444 run on x86_64-darwin 1

1 package failed to build:
  • beszel
beszel> npm error code 1
beszel> npm error path /private/tmp/nix-build-beszel-0.5.0.drv-0/source/beszel/site/node_modules/esbuild
beszel> npm error command failed
beszel> npm error command sh -c node install.js
beszel> npm error [esbuild] Failed to find package "@esbuild/darwin-x64" on the file system
beszel> npm error
beszel> npm error This can happen if you use the "--no-optional" flag. The "optionalDependencies"
beszel> npm error package.json feature is used by esbuild to install the correct binary executable
beszel> npm error for your current platform. This install script will now attempt to work around
beszel> npm error this. If that fails, you need to remove the "--no-optional" flag to use esbuild.
beszel> npm error
beszel> npm error [esbuild] Trying to install package "@esbuild/darwin-x64" using npm
beszel> npm error [esbuild] Failed to install package "@esbuild/darwin-x64" using npm: Command failed: npm install --loglevel=error --prefer-offline --no-audit --progress=false @esbuild/[email protected]
beszel> npm error npm error code ENOTCACHED
beszel> npm error npm error request to https://registry.npmjs.org/@esbuild%2fdarwin-x64 failed: cache mode is 'only-if-cached' but no cached response is available.
beszel> npm error npm error Log files were not written due to an error writing to the directory: /nix/store/ag4lal4pnjbiczrvhwmj1zrc129k25vm-beszel-0.5.0-npm-deps/_logs
beszel> npm error npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal
beszel> npm error
beszel> npm error [esbuild] Trying to download "https://registry.npmjs.org/@esbuild/darwin-x64/-/darwin-x64-0.21.5.tgz"
beszel> npm error [esbuild] Failed to download "https://registry.npmjs.org/@esbuild/darwin-x64/-/darwin-x64-0.21.5.tgz": unable to get local issuer certificate
beszel> npm error /private/tmp/nix-build-beszel-0.5.0.drv-0/source/beszel/site/node_modules/esbuild/install.js:273
beszel> npm error         throw new Error(`Failed to install package "${pkg}"`);
beszel> npm error               ^
beszel> npm error
beszel> npm error Error: Failed to install package "@esbuild/darwin-x64"
beszel> npm error     at checkAndPreparePackage (/private/tmp/nix-build-beszel-0.5.0.drv-0/source/beszel/site/node_modules/esbuild/install.js:273:15)
beszel> npm error     at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
beszel> npm error
beszel> npm error Node.js v20.17.0
beszel> npm error Log files were not written due to an error writing to the directory: /nix/store/ag4lal4pnjbiczrvhwmj1zrc129k25vm-beszel-0.5.0-npm-deps/_logs
beszel> npm error You can rerun the command with `--loglevel=verbose` to see the logs in your terminal

@Bot-wxt1221
Copy link
Member Author

@afh @mirkolenz I'm interested in how to fix it. I can find it build failed in ofborg.

@Bot-wxt1221 Bot-wxt1221 changed the title beszel: init at 0.5.0 beszel: init at 0.6.2 Oct 29, 2024
@Bot-wxt1221
Copy link
Member Author

@Aleksanaa Done.

@Aleksanaa
Copy link
Member

@ofborg build beszel

@Bot-wxt1221
Copy link
Member Author

Why succeed on x86 but fail on arm64.

@Bot-wxt1221
Copy link
Member Author

@Bot-wxt1221
Copy link
Member Author

@Aleksanaa Done.

@emilazy
Copy link
Member

emilazy commented Oct 29, 2024

Have you tested that this program runs and works correctly?

@Bot-wxt1221
Copy link
Member Author

@emilazy Yes.

image

@emilazy
Copy link
Member

emilazy commented Oct 29, 2024

Okay, if you’ve checked that the web server runs and the UI works correctly and reports statistics then this seems fine to me.

@emilazy
Copy link
Member

emilazy commented Oct 29, 2024

This package only contains the web UI, not the agent required to actually record any monitoring data. Is it intentional that you have not packaged the agent and that it is not possible to monitor NixOS systems with this software?

@MisileLab Is this package useful to you with only the web UI and no agent?

@MisileLab
Copy link
Contributor

This package only contains the web UI, not the agent required to actually record any monitoring data. Is it intentional that you have not packaged the agent and that it is not possible to monitor NixOS systems with this software?

@MisileLab Is this package useful to you with only the web UI and no agent?

actually my friend requested, I'll check it

@MisileLab
Copy link
Contributor

This package only contains the web UI, not the agent required to actually record any monitoring data. Is it intentional that you have not packaged the agent and that it is not possible to monitor NixOS systems with this software?
@MisileLab Is this package useful to you with only the web UI and no agent?

actually my friend requested, I'll check it

so I viewed docs and agent need to packaged.
but I thinks it needs to be packaged as seperated package because of special case like monitoring other's OS.

@Bot-wxt1221
Copy link
Member Author

We have agent. Maybe I should remove mainProgram.

image

@emilazy
Copy link
Member

emilazy commented Oct 29, 2024

Ah, apologies; I missed that executable. We shouldn’t install it as agent, that’s much too generic a name to put on the global $PATH. Upstream distributes the agent as a separate package, and calls the executable for the latter beszel-agent; we should probably match that, at least in terms of executable name and possibly in terms of a separate output or separate package altogether.

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Oct 31, 2024

@emilazy I have renamed it to beszel-

@Bot-wxt1221
Copy link
Member Author

Bot-wxt1221 commented Nov 6, 2024

@Aleksanaa Done. agent are used as server and hub are used as client.

@giorgiga
Copy link
Contributor

@Bot-wxt1221 I started the same work (I didn't notice it was already in progress). Wanna collaborate?

At the moment I have the packages for beszel and beszel-agent (for 0.7.4 but only tested on linux), I am almost done with a module for the agent and will (soon™) start on a module for the hub (the beszel dev is really helping a lot - see henrygd/beszel#275)

I see your package has a patch for package-lock.json, is that still relevant for 0.7.4?

@Aleksanaa Aleksanaa merged commit c00d32f into NixOS:master Nov 10, 2024
27 of 28 checks passed
@Aleksanaa
Copy link
Member

At the moment I have the packages for beszel and beszel-agent (for 0.7.4 but only tested on linux), I am almost done with a module for the agent and will (soon™) start on a module for the hub (the beszel dev is really helping a lot - see henrygd/beszel#275)

You can rebase on top of this and add module in a separated PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: beszel
7 participants