Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/swap: use btrfs mkswapfile if possible #340715

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Sep 9, 2024

Description of changes

Use btrfs filesystem mkswapfile to speed up the creation of swapfile under a btrfs mountpoint.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Use `btrfs filesystem mkswapfile` to speed up
the creation of swapfile under a btrfs mountpoint.
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@qbisi qbisi marked this pull request as draft October 31, 2024 22:49
@qbisi
Copy link
Contributor Author

qbisi commented Oct 31, 2024

Need to check if the nixos config support btrfs filesystem, avoid add redundent btrfs tools in ext4 only system

@qbisi
Copy link
Contributor Author

qbisi commented Oct 31, 2024

I am not familiar with zfs and bcachefs, maybe someone can add zfs or bcachefs related tools to speed up the creation of swapfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants