steam/fhsenv: use normal curl #340710
Merged
steam/fhsenv: use normal curl #340710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Steam Runtime can handle any curl version: https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/blob/main/libcurl-compat/README.md?ref_type=heads And nix-built applications run from Steam will start exploding on this after staging-next because we're finally building our curl with versioned symbols.
K900
added a commit
to K900/aagl-gtk-on-nix
that referenced
this pull request
Sep 9, 2024
This replicates the change from NixOS/nixpkgs#340710 But also, all of wrapAAGL is a huge mess with Steam-specific hacks copied from nixpkgs, which should really be cleaned up/removed.
SuperSandro2000
approved these changes
Sep 9, 2024
|
Tested this on a bunch of things and nothing broke. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The Steam Runtime can handle any curl version:
https://gitlab.steamos.cloud/steamrt/steam-runtime-tools/-/blob/main/libcurl-compat/README.md?ref_type=heads
And nix-built applications run from Steam will start exploding on this after staging-next because we're finally building our curl with versioned symbols.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.