switchres: init at 2.2.1 #340709
Open
switchres: init at 2.2.1 #340709
+60
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bot-wxt1221
force-pushed
the
switchres
branch
from
bcba05e
to
a9d7ac4
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4547 |
Bot-wxt1221
force-pushed
the
switchres
branch
from
a9d7ac4
to
d06d3e6
Compare
|
Result of 1 package built:
|
DataHearth
approved these changes
Sep 9, 2024
|
Tried to run this on my system and it's not working to actually set the generated modelines to an output: [nix-shell:~]$ sudo switchres 320 240 60 -i /home/damian/Emulation/test/switchres.ini
[sudo] password for damian:
Switchres(v2.2.1) add display[0]
Switchres: display[0] options: monitor[generic_15] generation[on]
Switchres: Monitor range 15625.00-15750.00,49.50-65.00,2.000,4.700,8.000,0.064,0.192,1.024,0,0,192,288,448,576
Switchres: Calculating best video mode for [email protected] orientation: normal
Switchres: could not find a video mode that meets your specsThings I tried:
Manually adding the generated modeline from this: [nix-shell:~]$ switchres 320 240 60 -i /home/damian/Emulation/test/switchres.ini -c
Switchres(v2.2.1) add display[0]
Switchres: display[0] options: monitor[generic_15] generation[on]
Switchres: Monitor range 15625.00-15750.00,49.50-65.00,2.000,4.700,8.000,0.064,0.192,1.024,0,0,192,288,448,576
Switchres: Calculating best video mode for [email protected] orientation: normal
Switchres: ( 0)x( 0)_(0=0.000000Hz)
rng(0): 320 x 240_60.000000p 15.660000 [integ] scale(1.000, 1.000, 1.000) diff(0.000, 0.000, 0.000)
Switchres: normal ([email protected])->([email protected])
rng(0): 320 x 240_60.000000p 15.660000 [integ] scale(1.000, 1.000, 1.000) diff(0.000, 0.000, 0.000)
Switchres: Modeline "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync
Switchres: success adding mode dummy timing "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync
Switchres: success deleting mode dummy timing "320x240_60 15.660000KHz 60.000000Hz" 6.514560 320 333 364 416 240 242 245 261 -hsync -vsync...with xrandr and setting the screen to it does work so I don't necessarily think it's a hardware fault or the kernel patch fault. When switchres is building these lines come up which might be the reason: |
Bot-wxt1221
force-pushed
the
switchres
branch
from
d06d3e6
to
754161a
Compare
|
@damiankorcz Try again with this. |
|
@Bot-wxt1221 It erroring out on the ports from the Nvidia card makes sense since they aren't supposed to work with this but the |
|
@damiankorcz [ERROR] missing X11_LIBRARY library So the prebuilt work? https://github.com/antonioginer/switchres/releases/tag/v2.2.1 |
|
@Bot-wxt1221 Not sure why it's complaining about X11. I'm booted up into KDE 6 with X11.
But to does seem to building ok now. Here is the full build log: Could it be with how I'm running it? Sorry I'm fairly new to NixOS so still figuring some of these things out 😅 |
|
I've found mentions of the following packages:
Potentially those missing are causing the X11 issue. Sources (both from the same individual on different platforms):
More context as to why it might be required to have the development packages included: |
|
@damiankorcz It is caused by the runtime library dependencies. I will patch the path later. |
Bot-wxt1221
force-pushed
the
switchres
branch
from
754161a
to
e2b1fdc
Compare
|
Jackpot 🥳 18ae1036-053d-4120-a123-3d0616cc02bb.mp4All seems to be working as intended now. Awesome job! Thank you @Bot-wxt1221 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1946 |
|
@damiankorcz Could you approval this PR? |
|
Result of 1 package built:
|
|
LGTM. Works as intended. |
|
We should wait for an nixpkgs committer anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
fix #340668
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.