pytest-alembic: init at 0.11.1 #340339
Open
pytest-alembic: init at 0.11.1 #340339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4535 |
RCoeurjoly
force-pushed
the
pytest-alembic
branch
from
ca969c8
to
50c399c
Compare
Co-authored-by: Abdullah Imad <[email protected]> Co-authored-by: Alberto Merino <[email protected]> Co-authored-by: Enric Morales <[email protected]> Co-authored-by: Jack Leightcap <[email protected]> Co-authored-by: Roland Coeurjoly <[email protected]>
RCoeurjoly
force-pushed
the
pytest-alembic
branch
from
50c399c
to
09a1edc
Compare
ViZiD
suggested changes
Sep 8, 2024
natsukium
reviewed
Sep 9, 2024
| nativeBuildInputs = [ poetry-core ]; | ||
| dependencies = [ | ||
| alembic | ||
| pytest |
There was a problem hiding this comment.
pytest should go to buildInputs to easily override pytest.
See other pytest plugins for a reference.
| pytest | ||
| sqlalchemy | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Could you enable tests with pythonImportsCheck and pytestCheckHook?
https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md#testing-python-packages-testing-python-packages
Co-authored-by: Radik Islamov <[email protected]>
Co-authored-by: Radik Islamov <[email protected]>
Co-authored-by: OTABI Tomoya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.