Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typst-lsp: fix by updating dependencies #336523

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Aug 22, 2024

Description of changes

typst-lsp is part of the packages that got broken when by the rust toolchain update to 1.80.
I have made a PR upstream to fix the issue, but it has not been merged yet.
In the meantime, I marked the package as broken.
In this PR, I simply backport the fix from the upstream PR to nixpkgs as a temporary fix.

Context: nvarner/typst-lsp#515

  • typst-lsp: fix by updating dependencies
  • typst-lsp: format and clean
  • typst-lsp: move to pkgs/by-name

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage mentioned this pull request Aug 22, 2024
13 tasks
@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336523 run on x86_64-linux 1

2 packages built:
  • typst-lsp
  • vscode-extensions.nvarner.typst-lsp

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336523 run on aarch64-darwin 1

2 packages built:
  • typst-lsp
  • vscode-extensions.nvarner.typst-lsp

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336523 run on aarch64-linux 1

2 packages built:
  • typst-lsp
  • vscode-extensions.nvarner.typst-lsp

@GaetanLepage
Copy link
Contributor Author

Result of nixpkgs-review pr 336523 run on x86_64-darwin 1

2 packages built:
  • typst-lsp
  • vscode-extensions.nvarner.typst-lsp

@drupol drupol merged commit 363da52 into NixOS:master Aug 22, 2024
49 of 51 checks passed
@GaetanLepage GaetanLepage deleted the typst-lsp branch August 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants